Skip to content

JavaScript: Teach autobuilder not to extract node_modules and bower_components folders.#2193

Merged
semmle-qlci merged 2 commits intogithub:masterfrom
max-schaefer:js/autobuilder-exclude-node_modules
Oct 28, 2019
Merged

JavaScript: Teach autobuilder not to extract node_modules and bower_components folders.#2193
semmle-qlci merged 2 commits intogithub:masterfrom
max-schaefer:js/autobuilder-exclude-node_modules

Conversation

@max-schaefer
Copy link
Contributor

No description provided.

@max-schaefer max-schaefer requested a review from a team as a code owner October 24, 2019 14:55
@ghost
Copy link

ghost commented Oct 24, 2019

CLA assistant check
All committers have signed the CLA.

@asger-semmle
Copy link
Contributor

asger-semmle commented Oct 24, 2019

Nice!

Perhaps we should run a short evaluation for some extra test coverage?

@max-schaefer
Copy link
Contributor Author

Good plan; I'll set something off to run overnight.

@max-schaefer
Copy link
Contributor Author

redo failed

@max-schaefer max-schaefer force-pushed the js/autobuilder-exclude-node_modules branch from f38ea8a to d4b9beb Compare October 25, 2019 13:25
@max-schaefer
Copy link
Contributor Author

Here (internal link) is a simplified report of a dist-compare with this PR on all projects that have a node_modules or bower_components folder. I have verified that the folders are excluded as expected.

The original report was obviously rather lengthy, so I have cut away all results in node_modules folders. This leaves five results that go away and four new results. None of them are particularly interesting, except for the last one which involves some rather entertaining tracking through callbacks. It is, however, not relevant for LGTM.com since it is in a part of node that we exclude, and moreover in test code.

So, on the whole I think the dist-compare report shows that this is a safe change to make.

Copy link
Contributor

@asger-semmle asger-semmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semmle-qlci semmle-qlci merged commit 30a9078 into github:master Oct 28, 2019
@max-schaefer max-schaefer deleted the js/autobuilder-exclude-node_modules branch October 31, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants