Skip to content

Python: Improve qldoc for ClassValue::getABaseType#2194

Merged
tausbn merged 1 commit intogithub:masterfrom
RasmusWL:python-improve-getbasetype-qldoc
Oct 28, 2019
Merged

Python: Improve qldoc for ClassValue::getABaseType#2194
tausbn merged 1 commit intogithub:masterfrom
RasmusWL:python-improve-getbasetype-qldoc

Conversation

@RasmusWL
Copy link
Copy Markdown
Member

Hopefully it is more clear that you can get multiple results from getABaseType
because of multiple inheritance, and no because we are following the chain of
inheritance

@RasmusWL RasmusWL changed the title qtausbnPython: Improve qldoc for ClassValue::getABaseType Python: Improve qldoc for ClassValue::getABaseType Oct 24, 2019
@RasmusWL RasmusWL requested a review from taus-semmle October 24, 2019 15:08
@RasmusWL RasmusWL self-assigned this Oct 24, 2019
@RasmusWL RasmusWL requested a review from tausbn October 24, 2019 15:09
@RasmusWL RasmusWL assigned tausbn and unassigned RasmusWL and tausbn Oct 24, 2019
@RasmusWL RasmusWL removed the request for review from taus-semmle October 24, 2019 15:09
Hopefully it is more clear that you can get multiple results from getABaseType
because of multiple inheritance, and not because we are following the chain of
inheritance
@RasmusWL RasmusWL force-pushed the python-improve-getbasetype-qldoc branch from 01ad9ba to c50d366 Compare October 24, 2019 15:10
@RasmusWL
Copy link
Copy Markdown
Member Author

I'm also starting to wonder if having getASuperType as an alias for getABaseType* is really required, but maybe we can talk about this? :)

Copy link
Copy Markdown
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@tausbn tausbn merged commit 04e3683 into github:master Oct 28, 2019
@RasmusWL RasmusWL deleted the python-improve-getbasetype-qldoc branch October 28, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants