Ruby: Address testFailures in inline expectations tests (part 1)#22078
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Ruby inline-expectations library tests by adding missing inline expectation annotations and updating the corresponding .expected files so the testFailures sections are empty again.
Changes:
- Added missing inline expectation markers (including
SPURIOUSwhere appropriate) in Ruby test sources. - Updated affected
.expectedfiles to remove previously recordedUnexpected resultfailures.
Show a summary per file
| File | Description |
|---|---|
| ruby/ql/test/library-tests/frameworks/action_controller/params-flow.expected | Removes testFailures entries now covered by inline expectations in filter_flow.rb. |
| ruby/ql/test/library-tests/frameworks/action_controller/filter_flow.rb | Adds inline expectation tags for taint flow (and marks expected false positives as SPURIOUS). |
| ruby/ql/test/library-tests/dataflow/string-flow/string-flow.expected | Removes testFailures entries now accounted for by inline expectations in string_flow.rb. |
| ruby/ql/test/library-tests/dataflow/string-flow/string_flow.rb | Adds inline expectation tags for value-flow false positives (and annotates them as SPURIOUS). |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Low
hvitved
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address testFailures in inline expectations tests. Annotations should always be updated so that the
testFailuressection of the.expectedfile is empty.I don't think there are any surprises here, just some missing inline expectations tags.