Skip to content

Ruby: Address testFailures in inline expectations tests (part 1)#22078

Merged
geoffw0 merged 2 commits into
github:mainfrom
geoffw0:rubyinline
Jun 29, 2026
Merged

Ruby: Address testFailures in inline expectations tests (part 1)#22078
geoffw0 merged 2 commits into
github:mainfrom
geoffw0:rubyinline

Conversation

@geoffw0

@geoffw0 geoffw0 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Address testFailures in inline expectations tests. Annotations should always be updated so that the testFailures section of the .expected file is empty.

I don't think there are any surprises here, just some missing inline expectations tags.

Copilot AI review requested due to automatic review settings June 29, 2026 08:42
@geoffw0 geoffw0 requested a review from a team as a code owner June 29, 2026 08:42
@geoffw0 geoffw0 added no-change-note-required This PR does not need a change note Ruby labels Jun 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Ruby inline-expectations library tests by adding missing inline expectation annotations and updating the corresponding .expected files so the testFailures sections are empty again.

Changes:

  • Added missing inline expectation markers (including SPURIOUS where appropriate) in Ruby test sources.
  • Updated affected .expected files to remove previously recorded Unexpected result failures.
Show a summary per file
File Description
ruby/ql/test/library-tests/frameworks/action_controller/params-flow.expected Removes testFailures entries now covered by inline expectations in filter_flow.rb.
ruby/ql/test/library-tests/frameworks/action_controller/filter_flow.rb Adds inline expectation tags for taint flow (and marks expected false positives as SPURIOUS).
ruby/ql/test/library-tests/dataflow/string-flow/string-flow.expected Removes testFailures entries now accounted for by inline expectations in string_flow.rb.
ruby/ql/test/library-tests/dataflow/string-flow/string_flow.rb Adds inline expectation tags for value-flow false positives (and annotates them as SPURIOUS).

Review details

  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Low

@geoffw0 geoffw0 merged commit 3058198 into github:main Jun 29, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-change-note-required This PR does not need a change note Ruby

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants