JS: Block XSS flow through encodeURIComponent#2216
Merged
semmle-qlci merged 1 commit intogithub:masterfrom Oct 30, 2019
Merged
Conversation
max-schaefer
suggested changes
Oct 28, 2019
Contributor
max-schaefer
left a comment
max-schaefer
left a comment
There was a problem hiding this comment.
LGTM, I think that's a fine solution for now. Needs a change note, though.
Contributor
Author
|
Evaluation looks fine. We lose one result which looks like a FP anyway. |
Contributor
Author
|
I believe it's already covered by the existing change note:
|
max-schaefer
approved these changes
Oct 30, 2019
This was referenced Oct 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strawman solution to #2196. Haven't run an evaluation yet as we're a bit low on machines.