Query cpp/unused-static-variable was producing incorrect results for constexpr variables#2239
Merged
jbj merged 1 commit intogithub:masterfrom Nov 1, 2019
dragonmux:master
Merged
Query cpp/unused-static-variable was producing incorrect results for constexpr variables#2239jbj merged 1 commit intogithub:masterfrom dragonmux:master
jbj merged 1 commit intogithub:masterfrom
dragonmux:master
Conversation
…constexpr variables
|
|
jbj
approved these changes
Nov 1, 2019
Contributor
jbj
left a comment
jbj
left a comment
There was a problem hiding this comment.
Thank you for the contribution! We've been trying lately to get the necessary information out of the C++ front-end that we use, but at this point we're out of ideas, so your workaround is most welcome.
I'll just run the tests, and then we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the query check that the variable is not constexpr before it will issue a warning.
This stops it producing false positives where the only uses, and therefore appearances in the AST, are constexpr, which results in the value of the variable rather than the variable itself appearing in the AST.