Python: Limit what functions we treat as returning sensitive data#2248
Merged
tausbn merged 1 commit intogithub:masterfrom Nov 4, 2019
Merged
Python: Limit what functions we treat as returning sensitive data#2248tausbn merged 1 commit intogithub:masterfrom
tausbn merged 1 commit intogithub:masterfrom
Conversation
Before this change, any function that has a parameter that was called password/credentials would be treated as returning sensitive data of that kind. `py/clear-text-logging-sensitive-data` would alert if one of these are logged, which has a LOT of false-positives.
tausbn
approved these changes
Nov 4, 2019
Contributor
tausbn
left a comment
tausbn
left a comment
There was a problem hiding this comment.
We discussed this already, and it looks good to me.
We should revisit this at a future date to see if there is some way to make use of sensitive-data-indicating keyword arguments, but for now I think it's fine to drop them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, any function that has a parameter that was called
password/credentials would be treated as returning sensitive data of that
kind.
py/clear-text-logging-sensitive-datawould alert if one of these arelogged, which has a LOT of false-positives.