JS: Skip CodeQL databases in AutoBuild#2258
Conversation
esbena
left a comment
esbena
left a comment
There was a problem hiding this comment.
LGTM, modulo potential incompleteness.
| throws IOException { | ||
| if (!dir.equals(currentRoot[0]) && (excludes.contains(dir) || dir.toFile().isHidden())) | ||
| return FileVisitResult.SKIP_SUBTREE; | ||
| if (dir.resolve("codeql-database.yml").toFile().exists()) { |
There was a problem hiding this comment.
Have we checked on #codeql-cli if that is the only new thing we should ignore?
There was a problem hiding this comment.
This ought to suffice for excluding databases made by the new CLI.
It won't take if you trick Odasa into creating a snapshot in a subdirectory of the source tree, but I believe doing so would takes quite a bit more coercion.
There was a problem hiding this comment.
Perhaps qlpack.yml, to avoid extracting test cases in existing qlpacks?
There was a problem hiding this comment.
That would be problematic for extracting a test directory that has its own qlpack.yml.
There was a problem hiding this comment.
By the way, why ...toFile().exists() rather than Files.exists(...)?
There was a problem hiding this comment.
Old habit I suppose. Switching to Files.exists().
esbena
left a comment
esbena
left a comment
There was a problem hiding this comment.
It sounds like this is good to go.
5 participants
No description provided.