Skip to content

CPP: Add tests of NtohlArrayNoBoundOpenSource.ql.#2273

Merged
rdmarsh2 merged 1 commit intogithub:masterfrom
geoffw0:ntohl
Nov 7, 2019
Merged

CPP: Add tests of NtohlArrayNoBoundOpenSource.ql.#2273
rdmarsh2 merged 1 commit intogithub:masterfrom
geoffw0:ntohl

Conversation

@geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Nov 7, 2019

Add tests of NtohlArrayNoBoundOpenSource.ql.

I looked into speeding up this query but made no gains; and with a suitably warmed up cache it turns out this query is reasonably quick already.

@geoffw0 geoffw0 added the C++ label Nov 7, 2019
@geoffw0 geoffw0 requested a review from a team as a code owner November 7, 2019 12:41
Copy link
Contributor

@rdmarsh2 rdmarsh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdmarsh2 rdmarsh2 merged commit ee185ea into github:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants