You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds a new parameter, DataFlowErasedType, to the implicit signature of the shared data flow implementation. The motivation is to be able to distinguish erased types from normal types: currently this is not done anywhere, but it will be in the C# implementation of type pruning.
AFAICS DataFlowType is then no longer used? Then I think it'll be cleaner to just reuse DataFlowType to mean what DataFlowErasedType currently means. If you then want to use distinct names in the C# implementation you should have both DataFlowType and DotNet::Type available to you.
Perhaps we could even get rid of getErasedRepr in the implicit signature and replace it with DataFlowType getDataFlowType(Node n) { getErasedRepr(n.getType()) }
AFAICS DataFlowType is then no longer used? Then I think it'll be cleaner to just reuse DataFlowType to mean what DataFlowErasedType currently means. If you then want to use distinct names in the C# implementation you should have both DataFlowType and DotNet::Type available to you.
You are right; I have changed DataFlowErasedType back to DataFlowType.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new parameter,
DataFlowErasedType, to the implicit signature of the shared data flow implementation. The motivation is to be able to distinguish erased types from normal types: currently this is not done anywhere, but it will be in the C# implementation of type pruning.