Java: Nullness library: track instanceof expressions in correlated conditions#2412
Merged
aschackmull merged 7 commits intogithub:masterfrom Nov 26, 2019
criemen:nullness-corr-cond
Merged
Java: Nullness library: track instanceof expressions in correlated conditions#2412aschackmull merged 7 commits intogithub:masterfrom criemen:nullness-corr-cond
aschackmull merged 7 commits intogithub:masterfrom
criemen:nullness-corr-cond
Conversation
aschackmull
requested changes
Nov 22, 2019
Contributor
There was a problem hiding this comment.
A few opportunities for simplification.
Also, do you have an example of a FP occurring in some project that the addition of correlated conditions of the form Sorry, I just noticed you pointed to such a FP on the issue.v1 == v2 fixes? I'm curious about the motivation for that addition.
Collaborator
Author
|
Thanks for the review, I addressed everything and renamed varComparisonExpr to varEqualityTestExpr. |
aschackmull
reviewed
Nov 25, 2019
aschackmull
previously approved these changes
Nov 25, 2019
Contributor
aschackmull
left a comment
aschackmull
left a comment
There was a problem hiding this comment.
LGTM. Will merge once the CI comes back green.
Contributor
|
The autoformat check on |
aschackmull
approved these changes
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a FP on apache kafka, see #2238 .
@aschackmull