Java: Improve performance by normalizing import order to reduce cache invalidation.#2447
Merged
yo-h merged 1 commit intogithub:masterfrom Nov 26, 2019
Merged
Conversation
yo-h
approved these changes
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a couple of queries that didn't start with
import java. This meant that imports were resolved in a different order for those queries resulting in slight DIL differences leading to recomputation of the virtual dispatch stage and all dependent stages (SSA etc.).I've verified locally by running all queries on a small snapshot that this removes the recomputation of the cached stages. This small change should thus be a clear performance improvement when running all queries.