Java: Improve performance and precision of DispatchFlow and thereby virtual dispatch. #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yh-semmle
reviewed
Oct 3, 2018
| } | ||
|
|
||
| /** Holds if `t` is a type that is relevant for dispatch flow. */ | ||
| predicate relevant(RefType t) { |
Contributor
There was a problem hiding this comment.
Should the added predicate and class perhaps remain private implementation details, or are they intended to be used elsewhere?
Contributor
Author
There was a problem hiding this comment.
No, they should indeed be private. Fixed.
yh-semmle
approved these changes
Oct 4, 2018
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Feb 7, 2022
Rename companion object QL class
MathiasVP
added a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
…odes PS: Add `Node.getCallee` predicate on `DataFlow::CallNode`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prunes the dispatch flow steps based on types. On jdk9 this reduces the set of call-callee pairs that are validated by dispatch flow from 460992 to 434463 (out of 1022290 candidate pairs for which dispatch flow is applied). The first commit contains the actual change, and the second commit just reorders the predicates.