Python: include zope web tests from internal repo#2482
Merged
tausbn merged 3 commits intogithub:masterfrom Dec 18, 2019
Merged
Conversation
RasmusWL
added
depends on internal PR
RasmusWL
changed the title
tausbn
requested changes
Dec 17, 2019
Contributor
tausbn
left a comment
tausbn
left a comment
There was a problem hiding this comment.
One minor question, otherwise LGTM.
| @@ -0,0 +1 @@ | |||
| semmle-extractor-options: --max-import-depth=3 -p ../../../query-tests/Security/lib/ --respect-init=False | |||
Contributor
There was a problem hiding this comment.
We removed --respect-init=False when moving the twisted tests. I'm wondering if it could be removed here as well, without affecting the tests.
Member
Author
There was a problem hiding this comment.
Good catch. I'm quite sure I was looking at some zope source code and noticed that they didn't have an zope/__init__.py file, which I why I did it like this. However, checking their codebase now I can see that they do in fact have a zope/__init__.py file. Fixed it up, and tests passed locally 👍
RasmusWL
force-pushed
the
python-include-zope-web-tests
branch
from
f4c857c to
8b5d6ae
Compare
tausbn
approved these changes
Dec 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the only part of the web modernisation, there was not any dedicated web library support for Zope, only these tests.
We do have the python/ql/src/semmle/python/libraries/Zope.qll file, but that isn't even used in this test
¯\_(ツ)_/¯