Prepare for codeql test:#2501
Merged
yo-h merged 3 commits intogithub:masterfrom Dec 10, 2019
hmakholm:test-extractors
Merged
Conversation
added 3 commits
December 7, 2019 02:38
The `queries.xml` file defines which extractor the `codeql test` runner will use to extract databases for the tests. In the future one will be able to write this information in `qlpack.yml`, but we can't do that immediately because the _existing_ CodeQL tooling would refuse to parse a `qlpack.yml` that has the new field in it. Adding a queries.xml file means that the normalization of file names in the test output changes even with the old QLTest, so there are a number of consequential updates of expected output files.
The `queries.xml` file defines which extractor the `codeql test` runner will use to extract databases for the tests. In the future one will be able to write this information in `qlpack.yml`, but we can't do that immediately because the _existing_ CodeQL tooling would refuse to parse a `qlpack.yml` that has the new field in it.
This allows them to work with the `LegacyQltLanguage.PYTHON3` extraction recipe.
max-schaefer
approved these changes
Dec 9, 2019
yo-h
approved these changes
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various changes to make the public unit tests compatible with the coming test-runner support in the CodeQL CLI:
Java, JavaScript: Add
queries.xmlfile. This defines which extractor thecodeql testrunner will use to extract databases for the tests. In the future one will be able to write this information inqlpack.yml, but we can't do that immediately because the existing CodeQL tooling would refuse to parse aqlpack.ymlthat has the new field in it.JavaScript: Adding a
queries.xmlfile means that the normalization of file names in the test output changes even with the old QLTest, so there are a number of consequential updates of expected output files.Python: Explicitly add a
--lang=2override to python2-specific tests. This ensures that the test driver does not need to depend on its own command-line options to know how to extract each test directory. (The new test driver will not, at least at first, be able to run the same test with either python2 or python3 depending on command-line settings. Since python2's end-of-life is fast approaching, this is probably an acceptable state of affairs going forward).