Add NetBSD/Solaris allocation functions.#2533
Add NetBSD/Solaris allocation functions.#2533jbj merged 1 commit intogithub:masterfrom m00nbsd:master
Conversation
m00nbsd
commented
Dec 16, 2019
m00nbsd
commented
- kmem_{z}alloc is used by Solaris and NetBSD
- pool_{cache_}get is used by NetBSD
|
|
jbj
left a comment
jbj
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I have one comment.
| name = "kmem_alloc" or | ||
| name = "kmem_zalloc" or | ||
| name = "pool_get" or | ||
| name = "pool_cache_get" |
There was a problem hiding this comment.
These names belong in the section below, under hasGlobalName. The section here, under hasGlobalOrStdName, is for function names that may exist both at the top level (like malloc from stdlib.h) and under std (like std::malloc from cstdlib).
There was a problem hiding this comment.
Alright, that should be better now
|
We can ignore the failing "Pull Request Labeler" check. I'll trigger the other checks after the initial PR feedback has been addressed. @geoffw0, do you have anything to add? |
* kmem_{z}alloc is used by Solaris and NetBSD
* pool_{cache_}get is used by NetBSD
|
LGTM. I think this will conflict with #2463, which I will fix after this is merged - but I'd appreciate a merge of 2463 before any further changes to Alloc.qll. |
3 participants
