C#: Handle tuple expressions#2563
Merged
hvitved merged 5 commits intogithub:masterfrom Jan 7, 2020
Merged
Conversation
hvitved
reviewed
Jan 6, 2020
| # It's useful (though not required) to be able to unpack codeql in the ql checkout itself | ||
| /codeql/ | ||
| .vscode/settings.json | ||
| csharp/extractor/Semmle.Extraction.CSharp.Driver/Properties/launchSettings.json |
Contributor
There was a problem hiding this comment.
Just checking: Did you intend to add these lines?
Contributor
Author
There was a problem hiding this comment.
Yes - it didn't merit its own PR.
| # It's useful (though not required) to be able to unpack codeql in the ql checkout itself | ||
| /codeql/ | ||
| .vscode/settings.json | ||
| csharp/extractor/Semmle.Extraction.CSharp.Driver/Properties/launchSettings.json |
Contributor
There was a problem hiding this comment.
Just checking: Did you intend to add these lines?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract tuple expressions, for example the body of
default((int,string)). Previously this expression would not be extracted and there would be an error incsharp.log.Fixes https://github.com/github/codeql-csharp-team/issues/3