JavaScript: Fix timeouts on bwip-js.#2574
Merged
semmle-qlci merged 2 commits intogithub:masterfrom Jan 6, 2020
Merged
Conversation
Contributor
Author
|
Evaluation is done (internal link) and confirms that the timeout on bwip-js is fixed. There is another, unrelated timeout on gecko-dev, which I will look into next in a separate PR. Finally, a (newly added?) babel test crashes our parser, which will be the topic of a third PR. |
erik-krogh
approved these changes
Jan 6, 2020
Contributor
erik-krogh
left a comment
erik-krogh
left a comment
There was a problem hiding this comment.
LGTM.
Finally, a (newly added?) babel test crashes our parser, which will be the topic of a third PR.
Yes, that is a newly added file in babel.
It started happening before the winter holidays. There is an internal issue for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were caused by two seemingly independent join mis-orderings which must have crept in fairly recently (certainly post-1.23).
I have verified that this PR fixes the original timeouts, a larger evaluation is ongoing.