JS: fix FP related to block-level flow type annotations#2581
Merged
semmle-qlci merged 2 commits intogithub:masterfrom Jan 6, 2020
Merged
JS: fix FP related to block-level flow type annotations#2581semmle-qlci merged 2 commits intogithub:masterfrom
semmle-qlci merged 2 commits intogithub:masterfrom
Conversation
max-schaefer
suggested changes
Jan 3, 2020
Contributor
max-schaefer
left a comment
There was a problem hiding this comment.
Nice! That's actually simpler than I thought. Could you add a test?
max-schaefer
approved these changes
Jan 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block-level flow type annotations were falsely flagged as useless-expressions.
E.g:
Currently the check is purely syntactical by inspecting the tokens to recognize the
(e: type)pattern.It doesn't seem like a nice way to do it, but it was the best I could get to work.
An evaluation shows that plenty of false positives are removed, and performance seems to be OK.