Python: Make web libs use HttpRequestTaintSource and HttpResponseTaintSink#2603
Merged
tausbn merged 11 commits intogithub:masterfrom Feb 12, 2020
Merged
Python: Make web libs use HttpRequestTaintSource and HttpResponseTaintSink#2603tausbn merged 11 commits intogithub:masterfrom
tausbn merged 11 commits intogithub:masterfrom
Conversation
RasmusWL
force-pushed
the
python-fix-http-source-sink
branch
from
4f873f6 to
e94a15d
Compare
Member
Author
|
Forgot to add an |
Some of the tests currently fail, since they can't reproduce the old tests results (since the sinks/sources defined in the library code are not HttpResponseTaintSink/HttpRequestTaintSource)
Naming these were a bit hard, but better than generic "Taint Sink"
`self.write(...)` would be treated as *both* TornadoConnectionWrite and TornadoHttpRequestHandlerWrite
I will fix this in an other PR
Since there are also HttpRedirectTaintSink, using HttpSink is confusing
RasmusWL
force-pushed
the
python-fix-http-source-sink
branch
from
04d8cfb to
c25782d
Compare
Member
Author
|
rebased & force-pushed so merge-conflict could be solved |
tausbn
previously approved these changes
Feb 5, 2020
tausbn
reviewed
Feb 5, 2020
RasmusWL
force-pushed
the
python-fix-http-source-sink
branch
from
e26ed5a to
d5c6092
Compare
tausbn
approved these changes
Feb 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using
TaintSourceandTaintSink, so our default queries will also be able to use them 🎉