C#: Fix cs/serialization-check-bypass#2658
Merged
hvitved merged 2 commits intogithub:masterfrom Feb 12, 2020
Merged
Conversation
hvitved
reviewed
Jan 23, 2020
calumgrant
force-pushed
the
cs/serialization-check-bypass-type
branch
from
6d79c26 to
4b90c56
Compare
calumgrant
force-pushed
the
cs/serialization-check-bypass-type
branch
from
4b90c56 to
7caae01
Compare
hvitved
reviewed
Jan 30, 2020
| not callable.calls*(checkedWrite(f, _, _).getEnclosingCallable()) | ||
| not callable.calls*(checkedWrite(f, _, _).getEnclosingCallable()) and | ||
| // Exclude object creations because they were not deserialized | ||
| not exists(ObjectCreation src | DataFlow::localExprFlow(src, result)) |
Contributor
There was a problem hiding this comment.
I think this should be generalized to
not exists(Epxr src |
DataFlow::localExprFlow(src, result)
|
src instanceof ObjectCreation
or
src.hasValue()
)
- Flow from expressions with a value is excluded.
hvitved
approved these changes
Feb 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove false-positives from this query, such as this one where the field is not serialized.