Skip to content

java: sharpen java/maven/non-https-url to allow localhost URLs #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aschackmull merged 3 commits into from
Jan 24, 2020
Merged

java: sharpen java/maven/non-https-url to allow localhost URLs #2685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a555880
java: add more tests for java/maven/non-https-url
esbena Jan 24, 2020
57b3a55
java: sharpen java/maven/non-https-url to allow localhost URLs
esbena Jan 24, 2020
8deefd6
java: fixup whitespace/tabs in test
esbena Jan 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions java/ql/src/Security/CWE/CWE-829/InsecureDependencyResolution.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ private class DeclaredRepository extends PomElement {
string getUrl() { result = getAChild("url").(PomElement).getValue() }

predicate isInsecureRepositoryUsage() {
getUrl().matches("http://%") or
getUrl().matches("ftp://%")
getUrl().regexpMatch("(?i)^(http|ftp)://(?!localhost[:/]).*")
}
}

Expand Down
5 changes: 3 additions & 2 deletions java/ql/test/query-tests/security/CWE-829/semmle/tests/InsecureDependencyResolution.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
| insecure-pom.xml:19:9:24:22 | repository | Downloading or uploading artifacts over insecure protocol (eg. http or ftp) to/from repository http://insecure-repository.example |
| insecure-pom.xml:25:9:30:30 | snapshotRepository | Downloading or uploading artifacts over insecure protocol (eg. http or ftp) to/from repository http://insecure-repository.example |
| insecure-pom.xml:33:9:38:22 | repository | Downloading or uploading artifacts over insecure protocol (eg. http or ftp) to/from repository http://insecure-repository.example |
| insecure-pom.xml:41:9:46:28 | pluginRepository | Downloading or uploading artifacts over insecure protocol (eg. http or ftp) to/from repository http://insecure-repository.example |
| insecure-pom.xml:31:9:36:30 | snapshotRepository | Downloading or uploading artifacts over insecure protocol (eg. http or ftp) to/from repository http://localhost.example |
| insecure-pom.xml:39:9:44:22 | repository | Downloading or uploading artifacts over insecure protocol (eg. http or ftp) to/from repository http://insecure-repository.example |
| insecure-pom.xml:47:9:52:28 | pluginRepository | Downloading or uploading artifacts over insecure protocol (eg. http or ftp) to/from repository http://insecure-repository.example |
6 changes: 6 additions & 0 deletions java/ql/test/query-tests/security/CWE-829/semmle/tests/insecure-pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@
<!-- BAD! Use HTTPS -->
<url>http://insecure-repository.example</url>
</snapshotRepository>
<snapshotRepository>
<id>insecure-snapshots</id>
<name>Insecure Repository Snapshots</name>
<!-- BAD! Use HTTPS -->
<url>http://localhost.example</url>
</snapshotRepository>
</distributionManagement>
<repositories>
<repository>
Expand Down
17 changes: 17 additions & 0 deletions java/ql/test/query-tests/security/CWE-829/semmle/tests/secure-pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,18 @@
<!-- GOOD! Use HTTPS -->
<url>https://insecure-repository.example</url>
</snapshotRepository>
<snapshotRepository>
<id>insecure-snapshots</id>
<name>Secure Repository Snapshots</name>
<!-- GOOD! Use HTTP, but for localhost -->
<url>http://localhost/snaphots</url>
</snapshotRepository>
<snapshotRepository>
<id>insecure-snapshots</id>
<name>Secure Repository Snapshots</name>
<!-- GOOD! Use HTTP, but for localhost -->
<url>http://localhost:82</url>
</snapshotRepository>
</distributionManagement>
<repositories>
<repository>
Expand All @@ -36,6 +48,11 @@
<!-- GOOD! Use HTTPS -->
<url>https://insecure-repository.example</url>
</repository>
<repository>
<id>test</id>
<!-- GOOD! Use HTTP, but for localhost -->
<url>http://localhost:${deploy.webserver.port}/repo</url>
</repository>
</repositories>
<pluginRepositories>
<pluginRepository>
Expand Down