Java: Add change note for LDAP injection query. #2738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felicitymay
reviewed
Feb 4, 2020
change-notes/1.24/analysis-java.md
Outdated
| |-----------------------------|-----------|--------------------------------------------------------------------| | ||
| | Disabled Spring CSRF protection (`java/spring-disabled-csrf-protection`) | security, external/cwe/cwe-352 | Finds disabled Cross-Site Request Forgery (CSRF) protection in Spring. | | ||
| | Failure to use HTTPS or SFTP URL in Maven artifact upload/download (`java/maven/non-https-url`) | security, external/cwe/cwe-300, external/cwe/cwe-319, external/cwe/cwe-494, external/cwe/cwe-829 | Finds use of insecure protocols during Maven dependency resolution. Results are shown on LGTM by default. | | ||
| | LDAP query built from user-controlled sources (`java/ldap-injection`) | security, external/cwe/cwe-090 | Finds LDAP queries vulnerable to injection of unsanitized user-controlled input. | |
Contributor
There was a problem hiding this comment.
Will this be run on LGTM? If so, will the results be shown or hidden, by default?
Contributor
Author
There was a problem hiding this comment.
Run and shown. I've elaborated the change notes for the new queries to say this.
felicitymay
approved these changes
Feb 4, 2020
Contributor
felicitymay
left a comment
felicitymay
left a comment
There was a problem hiding this comment.
Many thanks for the change note and the update.
Contributor
|
Does anyone else need to review this, or can I just merge it? |
Contributor
Author
|
Feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a change note for the query added in #2651.