C++: Support implicit casts better in range analysis#2750
Merged
dbartol merged 4 commits intogithub:masterfrom Feb 5, 2020
criemen:cpp-range-analysis-casts
Merged
C++: Support implicit casts better in range analysis#2750dbartol merged 4 commits intogithub:masterfrom criemen:cpp-range-analysis-casts
dbartol merged 4 commits intogithub:masterfrom
criemen:cpp-range-analysis-casts
Conversation
rdmarsh2
approved these changes
Feb 3, 2020
Contributor
rdmarsh2
left a comment
There was a problem hiding this comment.
Looks good to me. I've added expected test output by pushing to your branch.
Contributor
|
@jbj can we get @Cornelius-Riemenschneider a preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends the C++ range analysis by supporting constructs like
The bound derived in the if condition is on the value number of the implicitly-to-long converted i.
This PR recovers a bound on i itself.
Depends on #2745, *.expected test changes are missing due to missing tooling.