JavaScript: Add model of http2 compatibility API.#2845
Merged
semmle-qlci merged 2 commits intogithub:masterfrom Feb 14, 2020
Merged
JavaScript: Add model of http2 compatibility API.#2845semmle-qlci merged 2 commits intogithub:masterfrom
http2 compatibility API.#2845semmle-qlci merged 2 commits intogithub:masterfrom
Conversation
esbena
previously approved these changes
Feb 14, 2020
Contributor
|
LGTM, except for conflicts |
added 2 commits
February 14, 2020 11:14
Also deprecated the `httpOrHttps` predicate, which was now only used in one place and seemed a little pointless anyway.
max-schaefer
force-pushed
the
js/http2
branch
from
7277ebe to
ad83a89
Compare
Contributor
Author
|
Conflicts fixed. |
esbena
approved these changes
Feb 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also deprecated the
httpOrHttpspredicate, which was now only used in one place and seemed a little pointless anyway.Evaluation shows four new results on react. These true (though probably not exploitable) positives were the original motivation for this PR. Performance could look happier, but considering the very minor changes in this PR I'm inclined to attribute this to an acute case of the wobbles; let me know if you disagree, I'd be happy to rerun selected projects.