Code QL pre-migration tasks: update articles relating to CodeQL for JavaScript#2897
Conversation
|
2nd commit adds some intros but I'm afraid I won't get much further before we have to leave for the mini-summit. |
|
Please note that I haven't made any changes to do with content models and localization checklists. |
|
Thanks for the valuable review @intrigus-lgtm 👍 |
|
This PR is now ready for review.
|
|
Apologies for the automatic review request @jf205 and @shati-patel but I can't seem to be able to remove that (no cog icon for me to the right of the Reviewers section on the right hand-side). Is this due to a permissions thing on this repo? |
|
Since this is small text changes, I'm removing @jf205 ad @shati-patel as reviewers. Anyone in the docs team can review this PR. |
felicitymay
left a comment
There was a problem hiding this comment.
Thanks for the update. The new titles and associated changes to links look good.
Could you review the introductions? I'm not sure all articles have one (probably because you were interrupted in the middle of this work).
Co-Authored-By: Felicity Chapman <felicitymay@github.com>
Co-Authored-By: Felicity Chapman <felicitymay@github.com>
|
@felicitymay - thanks for your review. I believe I have addressed your comments. |
felicitymay
left a comment
There was a problem hiding this comment.
Thanks for the additional introductions. A couple of very minor suggestions. Ready to merge once you've accepted/rejected those suggestions.
Co-Authored-By: Felicity Chapman <felicitymay@github.com>
Co-Authored-By: Felicity Chapman <felicitymay@github.com>
|
@felicitymay - I have accepted your suggestions. Can you double-check you are ok with things now? Thanks. |
|
All LGTM 💚 |
See https://github.com/github/product-documentation/issues/2165 for details.
The first commit changes titles.