JS: fix an off-by-one error in the AngularJS expression AST #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
Deduplicate and sort union members
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Oct 28, 2021
Handle type parameters which are nullable without question mark
erik-krogh
added a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
add `ql/override-parameter-name`
erik-krogh
added a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
add `ql/override-parameter-name`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make
NgsingleFilter:getArgumentuse a zero-offset for its arguments.This PR also adds two tests to prevent related regressions.