JS: Flag deep assignments in prototype pollution query#2913
Merged
semmle-qlci merged 1 commit intogithub:masterfrom Mar 3, 2020
Merged
JS: Flag deep assignments in prototype pollution query#2913semmle-qlci merged 1 commit intogithub:masterfrom
semmle-qlci merged 1 commit intogithub:masterfrom
Conversation
asgerf
force-pushed
the
js/prototype-pollution-path
branch
from
a43d754 to
145697b
Compare
erik-krogh
reviewed
Feb 27, 2020
Contributor
erik-krogh
left a comment
erik-krogh
left a comment
There was a problem hiding this comment.
I'm ready to approve after these.
asgerf
force-pushed
the
js/prototype-pollution-path
branch
from
fa8a668 to
91843a8
Compare
Contributor
Author
|
Rebased to resolve change note conflict |
erik-krogh
previously approved these changes
Feb 27, 2020
Contributor
erik-krogh
left a comment
erik-krogh
left a comment
There was a problem hiding this comment.
LGTM assuming the tests are green.
asgerf
force-pushed
the
js/prototype-pollution-path
branch
from
91843a8 to
52ebe49
Compare
Contributor
Author
|
Squashed and rebased to resolve autoformat conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands the scope of the prototype pollution utility query to recognize "deep assignment" functions by treating
x.split(".")as a source of polluted property names.Evaluation looks reasonable. The new results aren't terribly interesting but looks legit. The only noticable slow down is in closure-library where there is also a new result, so the cost seems proportional.