JS: change alert location for js/incomplete-object-initialization #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiemaisi
suggested changes
Aug 8, 2018
| sc.getEnclosingFunction() != ctor | ||
| ) | ||
| select e, "The super constructor must be called before using '" + kind + "'." | ||
| select ctor, "The super constructor must be called before using '$@'.", e, kind |
There was a problem hiding this comment.
We generally want to avoid flagging multi-line entities, otherwise everything ends up looking very red on LGTM. You can use the RestrictedLocations library to only highlight the first line of the constructor.
xiemaisi
approved these changes
Aug 8, 2018
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
Simplify generated QL classes
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Oct 28, 2021
Kotlin: Improve the dbscheme generator
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
Autogenerate QLDoc for `TreeSitter.qll`
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
Autogenerate QLDoc for `TreeSitter.qll`
dbartol
pushed a commit
that referenced
this pull request
Dec 18, 2024
Treat branch-deploy action as a source of HEAD ref for untrusted checkouts
MathiasVP
pushed a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
…pslip Revert Zipslip to upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes ODASA-7268 by flagging constructors with invalid
this/superexpressions instead of the invalid expressions themselves. The expressions are still a part of the error message.This will prevent artificially high alert counts for some (legacy?) constructors.
Example: https://lgtm.com/projects/g/angular/watchtower.js/snapshot/50cb876f1b62f16e9beea51c8ca4209eadf84876/files/src/watch_group.js?sort=name&dir=ASC&mode=heatmap&showExcluded=true#x76858207ab8a9450:1