Merged
Conversation
aschackmull
force-pushed
the
java/zipslip
branch
from
b9a000d to
bbeb822
Compare
Contributor
|
It seems worth accounting for this sanitizer pattern in the sanitizer detection, provided you agree it's safe. |
Contributor
Author
I believe I already do account for that case? |
Contributor
Author
Of course, I should probably add it as a test case as well. |
aschackmull
force-pushed
the
java/zipslip
branch
from
7391b19 to
a50ebe2
Compare
yh-semmle
previously approved these changes
Oct 26, 2018
Contributor
|
There are some conflicts in the change note file. |
aschackmull
force-pushed
the
java/zipslip
branch
from
f6f080d to
c3f71c2
Compare
Contributor
Author
|
Rebased. |
yh-semmle
approved these changes
Oct 31, 2018
smowton
added a commit
to smowton/codeql
that referenced
this pull request
Apr 16, 2022
…eterized-class Accept anonymous parameterized types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ZipSlip query to Java, improving on the initial port done by @pavgust.
I've added support for other archive formats as implemented by
org.apache.commons.compress.archivers, and improved the sanitization detection.The qhelp is mostly copy-pasted from the C# query, but some parts have been rewritten somewhat to refer to the corresponding Java classes and methods.