Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Aug 8, 2018

The twitter-text library is included as source code in many of the projects we analyze. This PR classifies the library to prevent displaying alerts in it by default.

Example project with the library:
https://lgtm.com/projects/g/kneath/kneath.github.com/snapshot/5d889d781964a472f63b08337e73dbba9f18c15d/files/experiments/history-api/javascripts/lib/twitter_text.js?sort=name&dir=ASC&mode=heatmap&showExcluded=true

@ghost ghost added the JS label Aug 8, 2018
Copy link

@xiemaisi xiemaisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiemaisi
Copy link

xiemaisi commented Aug 9, 2018

This has picked up a conflict, and apparently also has a test failure.

@ghost ghost self-requested a review as a code owner August 15, 2018 06:51
@ghost
Copy link
Author

ghost commented Aug 15, 2018

Expected test output amended.
(My local git installation was smart enough to resolve the conflict automatically)

Copy link

@xiemaisi xiemaisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semmle-qlci semmle-qlci merged commit 6132b2c into github:master Aug 15, 2018
aibaars pushed a commit that referenced this pull request Oct 14, 2021
Remove cargo fmt workaround on OSX
smowton pushed a commit to smowton/codeql that referenced this pull request Oct 28, 2021
erik-krogh pushed a commit to erik-krogh/ql that referenced this pull request Dec 15, 2021
erik-krogh pushed a commit to erik-krogh/ql that referenced this pull request Dec 15, 2021
dbartol pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants