Java : add MongoDB injection sinks #3542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
ghost
mentioned this pull request
aschackmull
reviewed
Aug 13, 2020
Contributor
aschackmull
left a comment
aschackmull
left a comment
There was a problem hiding this comment.
LGTM overall. There has been a slight refactor of SqlInjectionLib.qll so a rebase would be good. And the test needs a little bit of attention - it appears it doesn't currently run (likely needs additional stubs).
Author
|
@aschackmull I have dded the stubs and rebased to the latest main. I think this should be ready to merge now. |
aschackmull
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds MongoDB sinks to the existing SQl injection query.