Skip to content

Conversation

@Fxyer
Copy link

@Fxyer Fxyer commented Jul 3, 2020

Server-side template injection occurs when user-controlled input is embedded into a server-side template, allowing users to inject template directives.

@Fxyer Fxyer requested a review from a team as a code owner July 3, 2020 05:52
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. We're currently in the process of reviewing a PR (#3396) that already implements support for detecting Server-Side Template Injections (including for Jinja2), so you may want to wait until that PR has been merged before adding more to this PR.

Also, I should add that we're currently rewriting large parts of the security analysis, so it may be best to wait until that work is done, as it will affect how we go about modelling libraries and do taint tracking. We expect this work to be done in a few months, and until then we do not plan on prioritising reviewing external submissions.

@RasmusWL
Copy link
Member

We're doing a bit of cleaning of old PRs, so going to close this one. Thanks for the original contribution 👍

@RasmusWL RasmusWL closed this May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants