JavaScript: Make access paths more reusable#3980
Closed
max-schaefer wants to merge 6 commits intogithub:mainfrom
Closed
JavaScript: Make access paths more reusable#3980max-schaefer wants to merge 6 commits intogithub:mainfrom
max-schaefer wants to merge 6 commits intogithub:mainfrom
Conversation
asgerf
reviewed
Jul 30, 2020
Contributor
asgerf
left a comment
asgerf
left a comment
There was a problem hiding this comment.
Thanks! LGTM apart from the one comment.
The test failure is probably due to line number shifting.
| */ | ||
| cached | ||
| predicate rhs2rhs(DataFlow::Node pred, DataFlow::Node succ, string step) { | ||
| any(DataFlow::PropWrite pw).writes(pred, step, succ) |
Contributor
There was a problem hiding this comment.
This predicate seems to be identical to ref2rhs.
Contributor
Author
There was a problem hiding this comment.
Ah, yes; I suppose that isn't really very useful. I'll remove it.
Contributor
Author
|
Thanks for the review, @asgerf! Comments addressed. |
asgerf
approved these changes
Jul 30, 2020
Contributor
Author
|
Looks like we won't immediately need this, so closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, this factors out a few reusable predicates from the access-path computation. The API graphs currently don't use this yet, so there is no particular rush to merge this, I just wanted to put it up for visibility and discussion.
An evaluation (internal link) shows a slight performance degradation. The massive apparent slowdown on gecko for the first run was due to the base SHA timing out on
definitions.qland the tip SHA timing out on a later query; on rerun, both timed out ondefinitions.ql.