Java: Add exec sinks with array arguments. #4051
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks fine to me, although I don't really like the increase in false positives. We now flag any remote user input that flows into the command array, while really the most dangerous is the first element in the array or potentially the others if the first is some sort of shell or interpreter (java, python, etc). I suppose we can refine the query later if the false positive rate is considered too high. |
aibaars
approved these changes
Aug 31, 2020
Contributor
Author
|
Superseded by #4287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The few additional results (https://lgtm.com/query/1236408154146688854/) seem like an improvement.