C#: Use DataFlow3 instead of DataFlow2 in Xml.qll to avoid overlap#4079
Merged
hvitved merged 1 commit intogithub:mainfrom Aug 17, 2020
Merged
C#: Use DataFlow3 instead of DataFlow2 in Xml.qll to avoid overlap#4079hvitved merged 1 commit intogithub:mainfrom
DataFlow3 instead of DataFlow2 in Xml.qll to avoid overlap#4079hvitved merged 1 commit intogithub:mainfrom
Conversation
`semmle.code.csharp.frameworks.system.Xml` is imported in `LibraryTypeDataFlow.qll`, and therefore part of the default namespace. This means that the use of `DataFlow2` inside `Xml.qll` overlaps with some queries. Bumping to `DataFlow3` resolves the issue.
tamasvajk
approved these changes
Aug 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
semmle.code.csharp.frameworks.system.Xmlis imported inLibraryTypeDataFlow.qll,and therefore part of the default namespace. This means that the use of
DataFlow2inside
Xml.qlloverlaps with some queries. Bumping toDataFlow3resolves the issue.CSharp-Differences job: https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/351/.