Java: Use the instance argument type in call contexts. #4081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Curious to see what the effect is on performance and results. |
Contributor
Author
Contributor
Author
|
With a suitable test configuration in scope, quick-eval'ing the following on JDK11 yields:
|
aschackmull
force-pushed
the
java/dispatch-ctx-this-param
branch
from
312af37 to
bcad18f
Compare
Contributor
Author
|
I've rebased and rerun the tuple counts since we now apply call contexts in the final pruning stage. Numbers are still looking good:
|
Contributor
Author
Contributor
|
Seems like this had real impact 🎉 : |
aschackmull
added a commit
to aschackmull/ql
that referenced
this pull request
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the call contexts used in data flow by also considering the type of the instance argument. Recent experience from C# has shown this to be especially helpful when dealing with the visitor pattern.