QL language reference: update links to match GitHub docs style #4091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2020 21:08
shati-patel
previously approved these changes
Aug 18, 2020
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Thanks for doing this pretty tedious work, and tidying up some extra stuff in the meantime! 🥇
All your changes look good. From a quick scan through the docs, I've found a few extra "quotable" links, just for consistency:
- Predicates: line 35 and 150
- Queries: "Apart from the expressions described in Expressions..."
- Modules: "... contain any of the elements listed in Module bodies ..." (x3)
- Lexical syntax: Probably all three links in this article?
Contributor
Author
|
Thanks @shati-patel 🦅 👀 ✨ |
shati-patel
approved these changes
Aug 18, 2020
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Great, thanks for the updates! ⚡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/github/semmle-docs/issues/218.
Follow up to #4046. Adds quotes around links where appropriate, in accordance with the GitHub style guide. There are lots of inline links in these topics that should probably be updated, but that work is beyond the scope of this PR.