Python: Shared dataflow, post-update nodes#4161
Merged
codeql-ci merged 3 commits intogithub:mainfrom Aug 31, 2020
Merged
Conversation
aschackmull
previously approved these changes
Aug 28, 2020
RasmusWL
approved these changes
Aug 28, 2020
jbj
approved these changes
Aug 31, 2020
Contributor
jbj
left a comment
jbj
left a comment
There was a problem hiding this comment.
The changes that touch C/C++ LGTM!
hvitved
approved these changes
Aug 31, 2020
aschackmull
approved these changes
Aug 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds post-update nodes in the recommended places (arguments, loads, and stores). It updates local flow, but does not add any load steps or store steps, so there should be no resulting field flow yet.
The approach to defining post-update nodes is to define a subset of
Nodes calledPreUpdateNodes. These will have an associated synthetic post-update node referring to them, so we can simply extend this class whenever we want to mark newNodes as needing a post-update node. We might, for instance, want to add nodes to container stores.