Java: Minor fixup for SSA AdjacentUsesImpl::varBlockReaches#4246
Merged
aschackmull merged 2 commits intogithub:mainfrom Sep 21, 2020
Merged
Java: Minor fixup for SSA AdjacentUsesImpl::varBlockReaches#4246aschackmull merged 2 commits intogithub:mainfrom
aschackmull merged 2 commits intogithub:mainfrom
Conversation
This should not change anything in regards to correctness overall -- what we really care about is `varBlockStep`, and that checks `varOccursInBlock(v, b2)`. However, the comment is a bit easier to read together with the code now (and probably also gives slightly smaller predicate result size).
Contributor
|
Change looks ok. The predicate does shrink a bit, which is always nice, and it doesn't appear to affect the join-order. Could you make the same change in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not change anything in regards to correctness overall -- what we really care about is
varBlockStep, and that checksvarOccursInBlock(v, b2). However, the comment is a bit easier to read together with the code now (and probably also gives slightly smaller predicate result size).