C++: SimpleRangeAnalysis: Always normalize bounds after a computation#4252
Merged
MathiasVP merged 2 commits intogithub:mainfrom Sep 14, 2020
Merged
C++: SimpleRangeAnalysis: Always normalize bounds after a computation#4252MathiasVP merged 2 commits intogithub:mainfrom
MathiasVP merged 2 commits intogithub:mainfrom
Conversation
This stops some cases of `-0.0` from propagating through the range analysis, fixing a false positive on arvidn/libtorrent. There seems to be no need for a corresponding change in the caller of `getDefLowerBoundsImpl` since that predicate only contains computations that cannot introduce negative zero.
Contributor
Author
|
We might want to run a CPP-Differences job to validate this, but first I'll make sure the tests pass. |
Contributor
Author
|
The checks have passed, except for a check that's broken on all PRs. I've started https://jenkins.internal.semmle.com/job/Changes/job/CPP-Differences/1424. |
geoffw0
approved these changes
Sep 11, 2020
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
LGTM, will merge when the diff is complete.
Contributor
Author
|
The CPP-Differences job shows no result changes and no significant performance changes. There is a slight slowdown in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4243.