Increase insufficient key size value from 1024 to 2048#4255
Merged
tamasvajk merged 2 commits intogithub:mainfrom Sep 22, 2020
Merged
Increase insufficient key size value from 1024 to 2048#4255tamasvajk merged 2 commits intogithub:mainfrom
tamasvajk merged 2 commits intogithub:mainfrom
Conversation
tamasvajk
previously approved these changes
Sep 17, 2020
Contributor
tamasvajk
left a comment
tamasvajk
left a comment
There was a problem hiding this comment.
LGTM. Thank you @fatenhealy
tamasvajk
force-pushed
the
IncreaseInsufficientKeySizeValue
branch
2 times, most recently
from
1886ca2 to
2fd43f6
Compare
hvitved
previously approved these changes
Sep 22, 2020
tamasvajk
force-pushed
the
IncreaseInsufficientKeySizeValue
branch
from
2fd43f6 to
a89d13a
Compare
hvitved
approved these changes
Sep 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR will change this by increasing the key size from 1024-bit to 2048-bit to align with the same recommendation we are giving here.