C++: Use underlying type when checking whether a type is a single-field struct. #4270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
approved these changes
Sep 16, 2020
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this.
Contributor
|
The distro test failure is not plausibly related to this change (because it doesn't use any high level libraries), so I'm assuming it's just unreliable. Merging... |
MathiasVP
added a commit
to MathiasVP/ql
that referenced
this pull request
Sep 17, 2020
MathiasVP
added a commit
to MathiasVP/ql
that referenced
this pull request
Sep 17, 2020
rdmarsh2
pushed a commit
that referenced
this pull request
Sep 17, 2020
…ingle-field-flow C++: Fix bad join order introduced by #4270
luchua-bc
pushed a commit
to luchua-bc/ql
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the false negative in #4266.
The general dataflow rule for flow into a
LoadInstruction's memory operand requires an exact overlap. But when loading a field from a single-field struct, the overlap is aMustTotallyoverlap (and not aMustExactlyoverlap), so we need an additional rule insimpleOperandLocalFlowStepthat propagates dataflow to the memory operand when the load is from a single-field struct.Prior to this PR, we didn't detect that a load was from a single-field struct when the struct was hidden behind a typedef.