C#: Teach guards library about assertions and custom null checks #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
csharp/more-guards
branch
from
ae2f096 to
29f163f
Compare
calumgrant
approved these changes
Nov 15, 2018
Contributor
calumgrant
left a comment
calumgrant
left a comment
There was a problem hiding this comment.
Very nice indeed. I only had one comment as I read past. Do you have any performance measurements for this. Happy to merge as-is.
| * Holds if assertion `a` directly asserts that expression `e` evaluates to | ||
| * value `v`. | ||
| */ | ||
| predicate asserts(Assertion a, Expr e, AbstractValue v) { |
Contributor
There was a problem hiding this comment.
Drop parameter e here as it's not adding anything?
Contributor
Author
There was a problem hiding this comment.
It is used by the predicates that call asserts, so I would like to keep it in.
Contributor
Author
I tested performance on my usual set of projects, and no performance issues found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for assertions and custom null checks in the guards library (first 4 commits). Additionally, the PR fixes the guards implications logic (last commit), as dominance is important for correctness (as discussed offline with @aschackmull).
@calumgrant