JS: add http request server data as a RemoteFlowSource#4338
Merged
codeql-ci merged 1 commit intogithub:mainfrom Oct 1, 2020
Merged
JS: add http request server data as a RemoteFlowSource#4338codeql-ci merged 1 commit intogithub:mainfrom
codeql-ci merged 1 commit intogithub:mainfrom
Conversation
erik-krogh
force-pushed
the
nodejs-server-request-data
branch
2 times, most recently
from
3ba6e54 to
27fbd70
Compare
asgerf
reviewed
Oct 1, 2020
| * E.g. `chunk` in: `http.createServer().on('request', (req, res) => req.on("data", (chunk) => ...))`. | ||
| */ | ||
| private class ServerRequestDataEvent extends RemoteFlowSource, DataFlow::ParameterNode { | ||
| RequestSource req; |
Contributor
There was a problem hiding this comment.
I'd suggest doing this with HTTP::RequestSource rather than the NodeJS-specific one. Some web frameworks, like Express, exposes request objects that are actually Node.js request objects with a modified prototype.
erik-krogh
force-pushed
the
nodejs-server-request-data
branch
from
27fbd70 to
4dec217
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by a synthetic benchmark.
We don't gain any results on that benchmark, but we are one step closer.