Python: Hotfix performance problem with flask methods #4361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves runtime for command injection query on https://lgtm.com/projects/g/alibaba/funcraft from +200 seconds (I did not care to wait more) down to ~55 seconds on my machine. This type of tracking predicate with string as additional argument apparently causes trouble :|
yoff
approved these changes
Sep 29, 2020
Contributor
yoff
left a comment
yoff
left a comment
There was a problem hiding this comment.
That is a pity. Perhaps some fancy inlining could still allow this; the JS folks might like to hear about it..
RasmusWL
added a commit
to RasmusWL/codeql
that referenced
this pull request
Sep 30, 2020
Not that they actually had a huge problem right now, just that using the old pattern HAS lead to bad performance in the past. See github#4361
luchua-bc
pushed a commit
to luchua-bc/ql
that referenced
this pull request
Oct 16, 2020
Not that they actually had a huge problem right now, just that using the old pattern HAS lead to bad performance in the past. See github#4361
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves runtime for command injection query on https://lgtm.com/projects/g/alibaba/funcraft from +200 seconds (I did not care to wait more) down to ~55 seconds on my machine.
This type of tracking predicate with string as additional argument apparently causes trouble :|