Merged
Conversation
smowton
requested review from
felicitymay,
hubwriter,
jf205 and
mchammer01
as code owners
Closed
Contributor
|
javascript 👍 |
esbena
approved these changes
Oct 1, 2020
aibaars
approved these changes
Oct 1, 2020
Contributor
Author
|
What's the situation with the Jenkins outage -- are you happy to merge over the failures, or shall I wait and restart jobs as and when? |
felicitymay
approved these changes
Oct 1, 2020
Contributor
felicitymay
left a comment
felicitymay
left a comment
There was a problem hiding this comment.
Thanks for fixing these 😄
LGTM
Contributor
|
I've removed the other docs team reviewers since it doesn't seem necessary for us each to review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes those broken links mentioned in #4379 that are also linked from the Go repository. The exact doc linked from the stack-trace exposure query didn't seem to exist any longer, so I found another doc that talked about stack dumps.