Python: Fix bad join order in adjacentUseUseSameVar
#4544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusWL
approved these changes
Oct 23, 2020
Member
RasmusWL
left a comment
RasmusWL
left a comment
There was a problem hiding this comment.
Nice 💪 (and matches the fix that was discussed internally 👍)
hvitved
reviewed
Oct 26, 2020
| * ``` | ||
| */ | ||
| pragma[nomagic] | ||
| cached |
Contributor
There was a problem hiding this comment.
Why cached when this is only a helper predicate used by predicate that is already cached?
Contributor
Author
There was a problem hiding this comment.
Ah, good point. I think what happened here is I started out with a non-private helper predicate, which must be cached because the module is. For some reason I decided to make it cached rather than private (and then later on I made it private but forgot to remove the cached annotation).
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.