Java: Fix inheritance relation for co-/contra-variant subtypes. #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yh-semmle
approved these changes
Nov 14, 2018
aschackmull
added a commit
to aschackmull/ql
that referenced
this pull request
Nov 23, 2018
yh-semmle
added a commit
that referenced
this pull request
Nov 23, 2018
Java: Add change note for #459.
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Make comment on BarrierGuard more specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods on subtypes arising from variance have different signatures depending on the instantiation, so that part of the subtype relation should not contribute to inheritance of methods. This fixes some weird-looking FPs for ConfusingOverloading where a subtype of
Predicate<T>for a concrete typeThad bothtest(T)andtest(Object)where the latter was inherited transitively fromPredicate<?>.