JavaScript: Convert security queries to path queries where applicable.#462
Merged
semmle-qlci merged 14 commits intogithub:masterfrom Nov 14, 2018
Merged
JavaScript: Convert security queries to path queries where applicable.#462semmle-qlci merged 14 commits intogithub:masterfrom
semmle-qlci merged 14 commits intogithub:masterfrom
Conversation
added 14 commits
November 14, 2018 09:16
This is needed to correctly handle the case where `edges` is empty.
…nclude `nodes` and `edges` query predicates.
Author
|
Ping @hvitved and @aschackmull for interest. |
Contributor
asger-semmle
left a comment
asger-semmle
left a comment
There was a problem hiding this comment.
LGTM after a quick read. 👍
Contributor
|
LGTM. |
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
…-specific Make PathContainmentCheck more specific
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the same approach as #367.
The diff is rather intimidating, so I'd suggest commit-by-commit review.
I've verified that this does not degrade performance (largely thanks to the last commit), and that results are unaffected on our default benchmark projects.