C#: Add missing CFG edges for nested finally blocks#4780
Merged
hvitved merged 3 commits intogithub:mainfrom Dec 14, 2020
Merged
C#: Add missing CFG edges for nested finally blocks#4780hvitved merged 3 commits intogithub:mainfrom
finally blocks#4780hvitved merged 3 commits intogithub:mainfrom
Conversation
71b86c7 to
3531dde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In nested
finallyblocks such aswe were unable to distinguish whether the inner
finallyblock inherited anExceptionAcompletion from the outerthrowor the innerthrow. The (somewhat surprising) effect was that we were missing a CFG edge (highlighted):The solution is to record information about the nesting level of inherited completions, which enables us to distinguish the two cases. Commit-by-commit review is encouraged.
https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/670/